fix(imap): avoid IMAP move loops when DeltaChat folder is aliased #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a fix for the bug that was reported on the forum: https://support.delta.chat/t/messages-received-hours-days-later/2639 |
link2xt
force-pushed
the
link2xt/prevent-imap-move-loop
branch
from
f7b1464
to
f33cf0f
Compare
link2xt
force-pushed
the
link2xt/prevent-imap-move-loop
branch
from
f33cf0f
to
b4e12e3
Compare
|
Would be nice to have some test, but prefetch testing is hard. Maybe something like this in Python:
|
Some Dovecot servers are configured to alias "INBOX.DeltaChat" and "DeltaChat" to the same folder. In this case Delta Chat moves new emails from "INBOX" to "DeltaChat", but then discovers the same mail in "INBOX.DeltaChat" and tries to move it to "DeltaChat" again. Each time a MOVE command is issued to move the message from "INBOX.DeltaChat" to "DeltaChat", the message gets a new UID. To prevent such IMAP move loop between aliased folders, we do not move the message if we have already seen it on IMAP, i.e. we have its Message-ID in the `imap` table. Note that we do not use `rfc724_mid_exists`, because it checks the `msgs` table and would consider BCC-self messages seen even before we see them in the Inbox, preventing their move to the DeltaChat folder. Duplicate messages and messages without Message-IDs are not moved anymore, but this is better than having an infinite move loop.
link2xt
force-pushed
the
link2xt/prevent-imap-move-loop
branch
from
b4e12e3
to
9fb275b
Compare
|
Added a test, checked that it fails on |
Hocuri
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Dovecot servers are configured
to alias "INBOX.DeltaChat" and "DeltaChat" to the same folder. In this case Delta Chat moves new emails from "INBOX" to "DeltaChat", but then discovers the same mail in "INBOX.DeltaChat" and tries to move it to "DeltaChat" again.
Each time a MOVE command is issued to move the message from "INBOX.DeltaChat" to "DeltaChat", the message gets a new UID.
To prevent such IMAP move loop between aliased folders, we do not move the message if we have already seen it on IMAP, i.e. we have its Message-ID in the
imaptable.Note that we do not use
rfc724_mid_exists,because it checks the
msgstable and would consider BCC-self messages seen even before we see them in the Inbox, preventing their move to the DeltaChat folder.Duplicate messages and messages without Message-IDs are not moved anymore, but this is better
than having an infinite move loop.